Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIS-5] add serde to a number of types #430

Merged
merged 4 commits into from
May 14, 2024
Merged

[CIS-5] add serde to a number of types #430

merged 4 commits into from
May 14, 2024

Conversation

lassemoldrup
Copy link
Contributor

Purpose

Closes #422. Depends on Concordium/concordium-rust-sdk#194.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemoldrup lassemoldrup requested review from soerenbf and DOBEN May 7, 2024 14:35
@lassemoldrup lassemoldrup marked this pull request as ready for review May 7, 2024 14:38
DOBEN
DOBEN approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

concordium-cis2/Cargo.toml Outdated Show resolved Hide resolved
concordium-cis2/Cargo.toml Show resolved Hide resolved
concordium-cis2/src/lib.rs Show resolved Hide resolved
concordium-cis2/src/lib.rs Show resolved Hide resolved
examples/cis5-smart-contract-wallet/src/lib.rs Show resolved Hide resolved
concordium-cis2/src/lib.rs Show resolved Hide resolved
@lassemoldrup lassemoldrup merged commit 39a0dd1 into main May 14, 2024
17 checks passed
@lassemoldrup lassemoldrup deleted the cis5-add-serde branch May 14, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOBEN DOBEN DOBEN approved these changes

@soerenbf soerenbf Awaiting requested review from soerenbf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback/Improvements on the smart-contract-wallet implementation
2 participants
@lassemoldrup @DOBEN